Ronak Kanabar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40039 )
Change subject: soc/intel/common: Remove unused Kconfig ......................................................................
soc/intel/common: Remove unused Kconfig
Change-Id: Ie337fd727d72118c43aa869da1446ea4fceadc5b Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com --- M src/soc/intel/common/block/graphics/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40039/1
diff --git a/src/soc/intel/common/block/graphics/Kconfig b/src/soc/intel/common/block/graphics/Kconfig index 36cac22..4ab9200 100644 --- a/src/soc/intel/common/block/graphics/Kconfig +++ b/src/soc/intel/common/block/graphics/Kconfig @@ -2,11 +2,3 @@ bool help Intel Processor common Graphics support - -config SKIP_GRAPHICS_ENABLING - bool - depends on SOC_INTEL_COMMON_BLOCK_GRAPHICS - default n - help - Skip GT specific programming in coreboot to support - early parts without GT enable.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40039 )
Change subject: soc/intel/common: Remove unused Kconfig ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40039/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40039/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/common: Remove unused Kconfig Please add SKIP_GRAPHICS_ENABLING to the summary.
https://review.coreboot.org/c/coreboot/+/40039/3//COMMIT_MSG@8 PS3, Line 8: Why is it not used anymore?
Hello build bot (Jenkins), Subrata Banik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40039
to look at the new patch set (#4).
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING
It is use to skip GT specific programming in ICL, TGL and JSL. In following patches use of SKIP_GRAPHICS_ENABLING is removed.
https://review.coreboot.org/c/coreboot/+/40038 https://review.coreboot.org/c/coreboot/+/39313
TEST=checked iclrvp, jslrvp and tglrvp compilation. Change-Id: Ie337fd727d72118c43aa869da1446ea4fceadc5b Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com --- M src/soc/intel/common/block/graphics/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40039/4
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40039 )
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40039/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40039/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/common: Remove unused Kconfig
Please add SKIP_GRAPHICS_ENABLING to the summary.
Done
https://review.coreboot.org/c/coreboot/+/40039/3//COMMIT_MSG@8 PS3, Line 8:
Why is it not used anymore?
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40039 )
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40039/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40039/5//COMMIT_MSG@13 PS5, Line 13: https://review.coreboot.org/c/coreboot/+/39313 It's nicer to reference commits by their commit hash, however that only works after they are merged. e.g.
e5565c45cb (soc/intel/{icelake, tigerlake}: Remove DDI A lane programming)
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40039 )
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
Patch Set 5: Code-Review+2
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40039 )
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
Patch Set 5:
(1 comment)
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40039/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40039/5//COMMIT_MSG@13 PS5, Line 13: https://review.coreboot.org/c/coreboot/+/39313
It's nicer to reference commits by their commit hash, however that […]
once this one get merge, i will edit commit and refer both with commit hash https://review.coreboot.org/c/coreboot/+/40038
Hello build bot (Jenkins), Nico Huber, Subrata Banik, Aamir Bohra, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40039
to look at the new patch set (#6).
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING
It is use to skip GT specific programming in ICL, TGL and JSL. In following patches use of SKIP_GRAPHICS_ENABLING is removed.
b6a5239 (soc/intel/jasperlake: Remove DDI A lane programming) e5565c4 (soc/intel/{icelake, tigerlake}: Remove DDI A lane programming)
TEST=checked iclrvp, jslrvp and tglrvp compilation. Change-Id: Ie337fd727d72118c43aa869da1446ea4fceadc5b Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com --- M src/soc/intel/common/block/graphics/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40039/6
Hello build bot (Jenkins), Nico Huber, Subrata Banik, Aamir Bohra, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40039
to look at the new patch set (#7).
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING
It is use to skip GT specific programming in ICL, TGL and JSL. In following patches use of SKIP_GRAPHICS_ENABLING is removed.
b6a523927d (soc/intel/jasperlake: Remove DDI A lane programming) e5565c45cb (soc/intel/{icelake, tigerlake}: Remove DDI A lane programming)
TEST=checked iclrvp, jslrvp and tglrvp compilation. Change-Id: Ie337fd727d72118c43aa869da1446ea4fceadc5b Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com --- M src/soc/intel/common/block/graphics/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40039/7
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40039 )
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40039/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40039/5//COMMIT_MSG@13 PS5, Line 13: https://review.coreboot.org/c/coreboot/+/39313
once this one get merge, i will edit commit and refer both with commit hash […]
Done
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40039 )
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING
It is use to skip GT specific programming in ICL, TGL and JSL. In following patches use of SKIP_GRAPHICS_ENABLING is removed.
b6a523927d (soc/intel/jasperlake: Remove DDI A lane programming) e5565c45cb (soc/intel/{icelake, tigerlake}: Remove DDI A lane programming)
TEST=checked iclrvp, jslrvp and tglrvp compilation. Change-Id: Ie337fd727d72118c43aa869da1446ea4fceadc5b Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40039 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/common/block/graphics/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Aamir Bohra: Looks good to me, approved
diff --git a/src/soc/intel/common/block/graphics/Kconfig b/src/soc/intel/common/block/graphics/Kconfig index 36cac22..4ab9200 100644 --- a/src/soc/intel/common/block/graphics/Kconfig +++ b/src/soc/intel/common/block/graphics/Kconfig @@ -2,11 +2,3 @@ bool help Intel Processor common Graphics support - -config SKIP_GRAPHICS_ENABLING - bool - depends on SOC_INTEL_COMMON_BLOCK_GRAPHICS - default n - help - Skip GT specific programming in coreboot to support - early parts without GT enable.
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40039 )
Change subject: soc/intel/common: Remove unused Kconfig SKIP_GRAPHICS_ENABLING ......................................................................
Patch Set 8:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2116 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2115 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2114
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aamir Bohra (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)
-
Ronak Kanabar (Code Review)