Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Paul Menzel, Ronak Kanabar, Subrata Banik.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83770?usp=email )
Change subject: drivers/intel/fsp2: Add config for FSP uGOP eSOL
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/83770/comment/e9f110a8_d72b930b?usp... :
PS4, Line 475: a configurable
: text message
Where can it be configured?
This text message can be updated in ````fill_fspm_sign_of_life```` function, which is only called if this config is enabled.
But you are right it's not configurable but hardcoded at the moment so updating this statement.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83770?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0426ff7974a141ae9188b0098677b4cc97aee36
Gerrit-Change-Number: 83770
Gerrit-PatchSet: 6
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Wed, 07 Aug 2024 05:37:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org