Attention is currently required from: Johnny Lin, Ed Sharma, Paul Menzel, Martin Roth.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68637 )
Change subject: commonlib/fsp_relocate: Fix Coverity Issues
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/commonlib/fsp_relocate.c:
https://review.coreboot.org/c/coreboot/+/68637/comment/4322737c_66f75722
PS4, Line 653: if (fih_offset) {
Eddie, you may forgot to copy the coverity comment here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68637
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I635c62929e8be9a474a91a62c29c3b5ee9b0ee64
Gerrit-Change-Number: 68637
Gerrit-PatchSet: 4
Gerrit-Owner: Ed Sharma
aeddiesharma@fb.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Ed Sharma
aeddiesharma@fb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 17:48:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment