Attention is currently required from: Subrata Banik, Maulik V Vaghela, Sridhar Siricilla, Nick Vaccaro, Eric Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63552 )
Change subject: mb/google/brya: Reset XHCI controller while preparing for S5 ......................................................................
Patch Set 3: Code-Review+2
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63552/comment/704e1136_0d08e1b7 PS3, Line 13: resume `poweron`
https://review.coreboot.org/c/coreboot/+/63552/comment/152d1162_5af022b7 PS3, Line 15: resume `poweron`
https://review.coreboot.org/c/coreboot/+/63552/comment/05135ff4_dcfbf4de PS3, Line 31: resuming `powering on`
https://review.coreboot.org/c/coreboot/+/63552/comment/b0bc57db_1a5a19e4 PS3, Line 33: Upon resume `During poweron`
https://review.coreboot.org/c/coreboot/+/63552/comment/95871e59_da675f0b PS3, Line 35: PMC tries to send the IPC command, finally, results into timeout. `which results in a timeout.`
Patchset:
PS3: just some grammar sugggestion
File src/mainboard/google/brya/smihandler.c:
https://review.coreboot.org/c/coreboot/+/63552/comment/1844641d_47c9925a PS3, Line 16: ACPI_S5
did this also end up applying to S3? […]
fair point.