Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48753 )
Change subject: mb/intel/adlrvp: Make SI_ALL region within 16MiB ......................................................................
mb/intel/adlrvp: Make SI_ALL region within 16MiB
TEST=Able to build and boot ADLRVP.
Change-Id: I93da53f8835e0eec4cf4e78daab26332fd55d334 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/mainboard/intel/adlrvp/chromeos.fmd 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/48753/1
diff --git a/src/mainboard/intel/adlrvp/chromeos.fmd b/src/mainboard/intel/adlrvp/chromeos.fmd index 4866662..ee27e2f 100644 --- a/src/mainboard/intel/adlrvp/chromeos.fmd +++ b/src/mainboard/intel/adlrvp/chromeos.fmd @@ -1,5 +1,5 @@ FLASH@0xfe000000 32M { - SI_ALL 0x1081000 { + SI_ALL@0x0 0x1000000 { SI_DESC 0x1000 SI_EC 0x80000 SI_ME
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48753 )
Change subject: mb/intel/adlrvp: Make SI_ALL region within 16MiB ......................................................................
Patch Set 1:
Can we have a review here, please
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48753 )
Change subject: mb/intel/adlrvp: Make SI_ALL region within 16MiB ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48753 )
Change subject: mb/intel/adlrvp: Make SI_ALL region within 16MiB ......................................................................
Patch Set 1: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48753 )
Change subject: mb/intel/adlrvp: Make SI_ALL region within 16MiB ......................................................................
mb/intel/adlrvp: Make SI_ALL region within 16MiB
TEST=Able to build and boot ADLRVP.
Change-Id: I93da53f8835e0eec4cf4e78daab26332fd55d334 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48753 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/intel/adlrvp/chromeos.fmd 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/intel/adlrvp/chromeos.fmd b/src/mainboard/intel/adlrvp/chromeos.fmd index 4866662..ee27e2f 100644 --- a/src/mainboard/intel/adlrvp/chromeos.fmd +++ b/src/mainboard/intel/adlrvp/chromeos.fmd @@ -1,5 +1,5 @@ FLASH@0xfe000000 32M { - SI_ALL 0x1081000 { + SI_ALL@0x0 0x1000000 { SI_DESC 0x1000 SI_EC 0x80000 SI_ME
-
Angel Pons (Code Review) -
Hung-Te Lin (Code Review)
-
Subrata Banik (Code Review)
-
Tim Wawrzynczak (Code Review)