Change in coreboot[master]: [TESTME]asrock/e350m1: fix the VGA-related PCI resource allocation pr...
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38219 )
Change subject: [TESTME]asrock/e350m1: fix the VGA-related PCI resource allocation problems ......................................................................
[TESTME]asrock/e350m1: fix the VGA-related PCI resource allocation problems
This workaround helps to avoid the PCI resource allocation problems which happen if a discrete VGA adapter (i.e. AMD HD6670) has been plugged in to E350M1 board. It does not bring any downsides if there is no discrete VGA adapter.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I154724ae8b7d85e2af832fbb650b260d2a3650f1 --- M src/mainboard/asrock/e350m1/OemCustomize.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/38219/1
diff --git a/src/mainboard/asrock/e350m1/OemCustomize.c b/src/mainboard/asrock/e350m1/OemCustomize.c index 3534c80..ec9c940 100644 --- a/src/mainboard/asrock/e350m1/OemCustomize.c +++ b/src/mainboard/asrock/e350m1/OemCustomize.c @@ -88,5 +88,7 @@
void board_BeforeInitPost(struct sysinfo *cb, AMD_POST_PARAMS *InitPost) { + /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ + InitPost->MemConfig.BottomIo = 0xD0; InitPost->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *)PlatformMemoryTable; }
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38219 )
Change subject: [TESTME]asrock/e350m1: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1:
Please review, hopefully you have a spare discrete GPU to test this.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38219 )
Change subject: [TESTME]asrock/e350m1: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1:
Please review, hopefully you have a spare discrete GPU to test this.
Hello Denis 'GNUtoo' Carikli, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38219
to look at the new patch set (#2).
Change subject: [TESTME]asrock/e350m1: fix the VGA-related PCI resource allocation problems ......................................................................
[TESTME]asrock/e350m1: fix the VGA-related PCI resource allocation problems
This workaround helps to avoid the PCI resource allocation problems which happen if a discrete VGA adapter (i.e. AMD HD6670) has been plugged in to E350M1 board. It does not bring any downsides if there is no discrete VGA adapter.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I154724ae8b7d85e2af832fbb650b260d2a3650f1 --- M src/mainboard/asrock/e350m1/OemCustomize.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/38219/2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38219 )
Change subject: [TESTME]asrock/e350m1: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38219/2/src/mainboard/asrock/e350m1... File src/mainboard/asrock/e350m1/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/38219/2/src/mainboard/asrock/e350m1... PS2, Line 91: /* Set to 0x40 instead of 0xE0 to avoid the PCI resource allocation problems. */ : InitPost->MemConfig.BottomIo = 0x40; See CB:30987 comment here for more info about this change from 0xD0 to 0x40 - https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e...
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38219 )
Change subject: [TESTME]asrock/e350m1: fix the VGA-related PCI resource allocation problems ......................................................................
Abandoned
Superseded by CB:38472 (amd/agesa: Make BottomIo position configurable)
-
Mike Banon (Code Review)