Attention is currently required from: Jakub Czapiga, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76110?usp=email )
Change subject: mb/google/rex: Set TCC to 90°C
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76110/comment/dfe63626_517de768 :
PS3, Line 11:
Why 90 °C? What was the value before?
Earlier the value was 0 as default.
File src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/76110/comment/48c3315a_2061877c :
PS3, Line 39: Temporary
Why “temporary”?
This is currently tested on open board. Customer(s) can fine tune based on their thermal design on closed system later stage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76110?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0567b6240fcb53f38158c381b700169475cf3795
Gerrit-Change-Number: 76110
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Deepika Punyamurtula
deepika.punyamurtula@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 26 Jun 2023 12:22:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment