Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Arthur Heymans, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64864 )
Change subject: amdblocks/smm.h: Add header guards
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/smm.h:
https://review.coreboot.org/c/coreboot/+/64864/comment/ca1f9476_1f0bc4b0
PS1, Line 3: _AMDBLOCKS_SMM_H_
Is there a standard format for the header guards?
Looking over other headers in this folder, most are in the form "AMD_BLOCK_foo_H"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d01c36fa4695ee42d18701a90d1b96bceb5045f
Gerrit-Change-Number: 64864
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 01 Jun 2022 13:05:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment