Attention is currently required from: Furquan Shaikh, Martin Roth, Mathew King, Paul Menzel, EricR Lai.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50007 )
Change subject: mb/google/mancomb: Add new mainboard
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/google/mancomb/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/50007/comment/c2668515_40d1280a
PS9, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later
This mainboard will end up looking a lot like guybrush and we should look for opportunities to move […]
sharing a devicetree between two different base boards probably creates more trouble than it solves; on zork we had two different devicetrees for the ft5 vs. fp5 based boards. since guybrush and mancomb will be even more different, i'd say that it's a good idea to put them in separate directories.
we do have chipset devicetrees now, so we need to duplicate less things that are common to all boards using the same soc
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1264f44a0b986f7f7c89ac7b42f1e4e4119a35e6
Gerrit-Change-Number: 50007
Gerrit-PatchSet: 11
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 17 Feb 2021 18:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment