Attention is currently required from: Kevin Chiu. Hello Kevin Chiu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/51659
to review the following change.
Change subject: grunt/barla: Add ALC5682 ACPI I2S machine driver for barla ......................................................................
grunt/barla: Add ALC5682 ACPI I2S machine driver for barla
The is used for AMD board using ALC5682 and MAX98357 codec.
BUG=b:171755306 BRANCH=master TEST=emerge-grunt coreboot
Change-Id: I5f29a2d784a9fc749fff61a9c96c0a487b71a2d7 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl 1 file changed, 28 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/51659/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl index 837678a..84601d8 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl @@ -3,7 +3,7 @@ #include <amdblocks/acpimmio_map.h>
/* Grunt specific I2S machine driver */ -Device (I2S) +Device (I2S0) { Name (_HID, "AMD7219") Name (_CID, "AMD7219") @@ -28,3 +28,30 @@ Return (RBUF) } } + +Device (I2S1) +{ + Name (_ADR, 1) + Name (_HID, "AMDI5682") + Name (_CID, "AMDI5682") + + /* Device-Specific Data */ + Name (_DSD, Package () + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () + { + Package () { "bt-pad-enable", 1 }, + } + }) + + Method (_CRS, 0x0, Serialized) { + Name (RBUF, ResourceTemplate () { + // Memory resource is for MISC FCH register set. + // It is needed for enabling the clock. + Memory32Fixed(ReadWrite, MISC_MMIO_BASE, 0x100) + }) + + Return (RBUF) + } +}