Change in coreboot[master]: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation pro...
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38215 )
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
[TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems
This workaround helps to avoid the PCI resource allocation problems which happen if a discrete VGA adapter has been plugged in to a board of F2A85-M family. It does not bring any downsides if there is no discrete VGA adapter.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I1fc7e34b77d30a35d4c7a48ad35d458af96ca03d --- M src/mainboard/asus/f2a85-m/OemCustomize.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/38215/1
diff --git a/src/mainboard/asus/f2a85-m/OemCustomize.c b/src/mainboard/asus/f2a85-m/OemCustomize.c index ec79fc8..684ec6b 100644 --- a/src/mainboard/asus/f2a85-m/OemCustomize.c +++ b/src/mainboard/asus/f2a85-m/OemCustomize.c @@ -179,6 +179,8 @@
void board_BeforeInitPost(struct sysinfo *cb, AMD_POST_PARAMS *InitPost) { + /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ + InitPost->MemConfig.BottomIo = 0xD0; if (CONFIG(BOARD_ASUS_F2A85_M) || CONFIG(BOARD_ASUS_F2A85_M_PRO)) InitPost->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *) MemoryTable_M; else if (CONFIG(BOARD_ASUS_F2A85_M_LE))
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38215 )
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1:
Please review, hopefully you have a spare discrete GPU to test this.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38215 )
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1:
Please review, hopefully you have a spare discrete GPU to test this.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38215 )
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1:
I'll test it with an old S3 PCI VGA adapter.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38215 )
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1:
Patch Set 1:
I'll test it with an old S3 PCI VGA adapter.
Would be nice. I tested it with a PCIe HD6670 on a similar A88XM-E and it worked fine.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38215 )
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1: Code-Review+1
What problemm would this solve? Graphics comes up as expected, without this change (IE clean master).
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38215 )
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
What problemm would this solve? Graphics comes up as expected, without this change (IE clean master).
Maybe you didn't encounter this problem because you were using an old VGA adapter. I had this problem on almost identical A88XM-E with HD6670 adapter, then applied this fix and it's gone. Also, I haven't observed any downsides from this fix on various AGESA systems.
Hello Denis 'GNUtoo' Carikli, Rudolf Marek, Rudolf Marek, Idwer Vollering, build bot (Jenkins), Daniel Kulesz,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38215
to look at the new patch set (#2).
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
[TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems
This workaround helps to avoid the PCI resource allocation problems which happen if a discrete VGA adapter has been plugged in to a board of F2A85-M family. It does not bring any downsides if there is no discrete VGA adapter.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I1fc7e34b77d30a35d4c7a48ad35d458af96ca03d --- M src/mainboard/asus/f2a85-m/OemCustomize.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/38215/2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38215 )
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38215/2/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/38215/2/src/mainboard/asus/f2a85-m/... PS2, Line 182: /* Set to 0x40 instead of 0xE0 to avoid the PCI resource allocation problems. */ : InitPost->MemConfig.BottomIo = 0x40; See CB:30987 comment here for more info about this change from 0xD0 to 0x40 - https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e...
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38215 )
Change subject: [TESTME]asus/f2a85-m: fix the VGA-related PCI resource allocation problems ......................................................................
Abandoned
Superseded by CB:38472 (amd/agesa: Make BottomIo position configurable)
-
Idwer Vollering (Code Review) -
Mike Banon (Code Review)