Attention is currently required from: Tim Wawrzynczak. Rehan Ghori has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62591 )
Change subject: scout: i2c HID driver for Ilitek touchscreen ......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/google/hatch/variants/scout/gpio.c:
https://review.coreboot.org/c/coreboot/+/62591/comment/d6d30114_923029d0 PS1, Line 3: #include <gpio.h> : #include <baseboard/gpio.h> : #include <baseboard/variants.h> : #include <commonlib/helpers.h> : #include <types.h> : #include <soc/gpio.h> : #include <vendorcode/google/chromeos/chromeos.h>
nit: please keep alphabetical, i.e. […]
Done
File src/mainboard/google/hatch/variants/scout/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62591/comment/b60253bb_e3abb844 PS1, Line 389: register "generic.probed" = "1"
Are you running with a ChromeOS kernel? If not, then you will not need this, this is for a patch we […]
This variant "scout" does have a ChromeOS kernel.
https://review.coreboot.org/c/coreboot/+/62591/comment/97882722_59e0bb24 PS1, Line 392: "GPE0_DW0_16
Shouldn't this be […]
You are right, I wasn't sure about this and based it off the variant "Dooly" board but Dooly's pin is the A group, which makes sense, I'll update it.
-
Rehan Ghori (Code Review)