Attention is currently required from: Arthur Heymans, Bao Zheng, Martin L Roth, Martin Roth, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76499?usp=email )
Change subject: soc/amd/genoa: Deal with memory map for 32M or larger flash
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS9:
unresolved question.
i'd say that that should be made common once the genoa code has landed
File src/soc/amd/genoa/Kconfig:
https://review.coreboot.org/c/coreboot/+/76499/comment/214a97af_d63232fe :
PS10, Line 19: #TODO remove X86_CUSTOM_BOOTMEDIA
that comment doesn't really apply, since we'll have to use that option. sure, all this can be moved to the common amd code later on, but i'd keep it as it is for now and don't add this slightly misleading comment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76499?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffe5c17a50f3254411a4847c7e635ce0fd282fde
Gerrit-Change-Number: 76499
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 27 Sep 2023 16:16:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment