Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58114 )
Change subject: soc/amd/common/block/espi_util: Refactor eSPI Setup ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58114/comment/c6e7b8be_b13b0663 PS4, Line 7: ESPI
eSPI. some more instances below.
Done
File src/soc/amd/cezanne/early_fch.c:
https://review.coreboot.org/c/coreboot/+/58114/comment/3b757df7_59247149 PS4, Line 43: configure_espi();
see my comments on picasso's early_fch
Done
File src/soc/amd/picasso/early_fch.c:
https://review.coreboot.org/c/coreboot/+/58114/comment/ebb25371_4e6f2548 PS4, Line 48: and SPI Fast speed overrides based on : board version.
this isn't related to eSPI and also not what the code is doing
Implicitly board version involves talking with EC which requires ESPI setup. Given that it is optional, I removed it from the comment.
https://review.coreboot.org/c/coreboot/+/58114/comment/975bf856_cadd65b9 PS4, Line 50: configure_espi();
lpc_early_init needs to be called before configure_espi, since lpc_early_init calls lpc_set_spibase […]
Done