Change in coreboot[master]: cpu/x86/smm: Drop now unused `num_cpus` param

[Name of user not set (Code Review)]

[e-mail] has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40439 )

Change subject: cpu/x86/smm: Drop now unused `num_cpus` param
......................................................................

cpu/x86/smm: Drop now unused `num_cpus` param

Suggested by Nico Huber in CL 38767

Change-Id: Ib5c646a380bf8d8ca001a5f821f89998b21e9957
Signed-off-by: Eugene D Myers 
---
M src/cpu/x86/smm/smm_module_loader.c
M src/cpu/x86/smm/smm_stub.S
M src/include/cpu/x86/smm.h
3 files changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40439/1

diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c
index c50e97d..2279fe8 100644
--- a/src/cpu/x86/smm/smm_module_loader.c
+++ b/src/cpu/x86/smm/smm_module_loader.c
@@ -262,7 +262,6 @@
    stub_params->runtime.smbase = (uintptr_t)smbase;
    stub_params->runtime.smm_size = smm_size;
    stub_params->runtime.save_state_size = params->per_cpu_save_state_size;
-	stub_params->runtime.num_cpus = params->num_concurrent_stacks;

/* Initialize the APIC id to CPU number table to be 1:1 */
    for (i = 0; i < params->num_concurrent_stacks; i++)
diff --git a/src/cpu/x86/smm/smm_stub.S b/src/cpu/x86/smm/smm_stub.S
index 7e32036..edb8719 100644
--- a/src/cpu/x86/smm/smm_stub.S
+++ b/src/cpu/x86/smm/smm_stub.S
@@ -35,8 +35,6 @@
 .long 0
 save_state_size:
 .long 0
-num_cpus:
-.long 0
 /* allows the STM to bring up SMM in 32-bit mode */
 start32_offset:
 .long smm_trampoline32 - _start
diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h
index afa8cf4..0ed3847 100644
--- a/src/include/cpu/x86/smm.h
+++ b/src/include/cpu/x86/smm.h
@@ -54,7 +54,6 @@
    u32 smbase;
    u32 smm_size;
    u32 save_state_size;
-	u32 num_cpus;
    /* STM's 32bit entry into SMI handler */
    u32 start32_offset;
    /* The apic_id_to_cpu provides a mapping from APIC id to CPU number.

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40439 )

Change subject: cpu/x86/smm: Drop now unused `num_cpus` param
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40439/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40439/1//COMMIT_MSG@9 
PS1, Line 9: Suggested by Nico Huber in CL 38767
This should have a real explanation in the commit description.

[Eugene Myers (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40439

to look at the new patch set (#2).

Change subject: cpu/x86/smm: Drop now unused `num_cpus` param
......................................................................

cpu/x86/smm: Drop now unused `num_cpus` param

Suggested by Nico Huber in Cb:38767

Change-Id: Ib5c646a380bf8d8ca001a5f821f89998b21e9957
Signed-off-by: Eugene D Myers 
---
M src/cpu/x86/smm/smm_module_loader.c
M src/cpu/x86/smm/smm_stub.S
M src/include/cpu/x86/smm.h
3 files changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40439/2

[Eugene Myers (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40439

to look at the new patch set (#3).

Change subject: cpu/x86/smm: Drop now unused `num_cpus` param
......................................................................

cpu/x86/smm: Drop now unused `num_cpus` param

Suggested by Nico Huber in CB:38767

Change-Id: Ib5c646a380bf8d8ca001a5f821f89998b21e9957
Signed-off-by: Eugene D Myers 
---
M src/cpu/x86/smm/smm_module_loader.c
M src/cpu/x86/smm/smm_stub.S
M src/include/cpu/x86/smm.h
3 files changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40439/3

[Eugene Myers (Code Review)]

Eugene Myers has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40439 )

Change subject: cpu/x86/smm: Drop now unused `num_cpus` param
......................................................................

Abandoned

obsolete