c.koehne@beckhoff.com has posted comments on this change. ( https://review.coreboot.org/c/em100/+/80250?usp=email )
Change subject: em100: return an error if a command fails
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/em100/+/80250/comment/01095c16_cf16e2df :
PS1, Line 9: We don't properly return an error in every code path when a command fails. This
: makes it hard to use this tool in a shell script because you can't be sure that
: your command was successful.
:
Please match 72 characters line limit
Done
--
To view, visit
https://review.coreboot.org/c/em100/+/80250?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: main
Gerrit-Change-Id: I2554252d007a92e939088389d67f9d4cede837ee
Gerrit-Change-Number: 80250
Gerrit-PatchSet: 2
Gerrit-Owner: c.koehne@beckhoff.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 02 Feb 2024 10:21:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
czapiga@google.com
Gerrit-MessageType: comment