Attention is currently required from: Felix Singer, Lance Zhao, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60645 )
Change subject: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: IIRC, we decided against mixing old and new syntax within a file. IMO not a problem to split patches, though, as long as patches are organized such that it's visible to the reviewer that the whole file gets converted.
Please note in the commit messages if the resulting byte code changes. Then reviewers can focus on the changes where it does.
File src/arch/x86/acpi/debug.asl:
https://review.coreboot.org/c/coreboot/+/60645/comment/5ec4a1f6_47026838 PS1, Line 89: += Nit, not exactly what the commit message states.
-
Nico Huber (Code Review)