Attention is currently required from: Bob Moragues, Bob Moragues, Karthik Ramasubramanian, Kenneth Chan, Ren Kuo, Shelley Chen, Subrata Banik.
Paul Menzel has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84689?usp=email )
Change subject: mb/google/brox/jubilant: Modify WWAN Rolling RW101R-GL power sequence
......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84689/comment/7899260f_0e8ec1c6?usp... :
PS4, Line 9: There is no ACPI power resource for LTE mdule Rolling RW101R-GL
Could such a resource be added?
https://review.coreboot.org/c/coreboot/+/84689/comment/9262ed1b_095f43c3?usp... :
PS4, Line 9: mdule
module
https://review.coreboot.org/c/coreboot/+/84689/comment/f487ce95_0da2939b?usp... :
PS4, Line 10: power on
As it is *not* used as a verb here: poweron or power-on.
https://review.coreboot.org/c/coreboot/+/84689/comment/e94cc031_2ffe8b89?usp... :
PS4, Line 10: power off
Ditto.
https://review.coreboot.org/c/coreboot/+/84689/comment/3f91af16_916685d2?usp... :
PS4, Line 13:
What sources did you use to implement this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84689?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a205e3db777c7c225d31b6cc802883fd7167089
Gerrit-Change-Number: 84689
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Bob Moragues
moragues@chromium.org
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 16 Oct 2024 05:58:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No