Change in coreboot[master]: mb/google/nissa/var/nivviks: Add GL9750 power sequence - coreboot-gerrit

10 Mar 2022


      Attention is currently required from: Reka Norman, Tim Wawrzynczak.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62722 )
Change subject: mb/google/nissa/var/nivviks: Add GL9750 power sequence
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/nivviks/gpio.c:
https://review.coreboot.org/c/coreboot/+/62722/comment/3b01d96b_0185a623 
PS1, Line 35: PAD_CFG_GPO(GPP_H12, 0, DEEP),
...
nit: could you please move this down to keep them sorted?
I want let PREST low enough time before power goes high. Is that okay for you?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62722
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6d461a56f6aeba30994daafe8993c36df4b309d
Gerrit-Change-Number: 62722
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 03:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman rekanorman@chromium.org
Gerrit-MessageType: comment