[M] Change in coreboot[main]: chromeec/ec_acpi: Define ACPI devices for USB-C ports using UCSI

[Subrata Banik (Code Review)]

Attention is currently required from: Forest Mittelberg, Jameson Thies.

Subrata Banik has posted comments on this change by Jameson Thies. ( https://review.coreboot.org/c/coreboot/+/84404?usp=email )

Change subject: chromeec/ec_acpi: Define ACPI devices for USB-C ports using UCSI
......................................................................

Patch Set 3:

(2 comments)

File src/ec/google/chromeec/ec_acpi.c:

https://review.coreboot.org/c/coreboot/+/84404/comment/6a372d47_a1dc4632?usp... :
PS1, Line 200: 		usb2_port = NULL;
             : 		usb3_port = NULL;
             : 		usb4_port = NULL;
> I've added a NULL assignment when these are first defined but am leaving the assignment here. […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/84404/comment/e8a28493_9c547640?usp... :
PS1, Line 230: 			.orientation_switch = orientation_switch,
             : 			.usb_role_switch = usb_role_switch,
             : 			.mode_switch = mode_switch,
             : 			.retimer_switch = retimer_switch,
> I am not seeing much in the ACPI specification about valid assignments to the orientation and retimer switches. But, this is what we currently do for other `typec_config` properties. The assignment to usb4_port isn't guaranteed in `get_usb_port_references`. The usbX_port properties will default to a NULL.

I hope at least driver code checks that before dealing with those NULL parameters ?