Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44865 )
Change subject: soc/intel/common/block/smbus: Add config to use ACPI ......................................................................
soc/intel/common/block/smbus: Add config to use ACPI
Change-Id: Iafa7d40fc21e62f99dbdc2001ab6525a2a77ff50 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/soc/intel/common/block/smbus/Kconfig 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/44865/1
diff --git a/src/soc/intel/common/block/smbus/Kconfig b/src/soc/intel/common/block/smbus/Kconfig index fe940cc..818200e 100644 --- a/src/soc/intel/common/block/smbus/Kconfig +++ b/src/soc/intel/common/block/smbus/Kconfig @@ -3,6 +3,13 @@ help Intel Processor common SMBus support
+config SOC_INTEL_COMMON_BLOCK_SMBUS_ACPI_DRIVER + bool + default n + depends on SOC_INTEL_COMMON_BLOCK_SMBUS + help + Intel Processor SMBus ACPI driver support + config SOC_INTEL_COMMON_BLOCK_TCO bool help
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44865 )
Change subject: soc/intel/common/block/smbus: Add config to use ACPI ......................................................................
Patch Set 1:
where are you planning to use this? The only use I see in this patch train is the one on top of it, but nothing ever selects this Kconfig
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44865 )
Change subject: soc/intel/common/block/smbus: Add config to use ACPI ......................................................................
Patch Set 2:
Patch Set 1:
Thanks for the review.
where are you planning to use this? The only use I see in this patch train is the one on top of it, but nothing ever selects this Kconfig
I am setting this config for kontron mal10 (Apollo Lake) [1] board to ignore the warnings in CB:44866 and to build the acpi code for smbus (CB:44507). This is needed to access Nuvoton nct7802 HWM, which is connected to the SMBus.
I think this also needs to be done for the kontron/bsl6 (Sky/Kaby Lake) board as it also uses nct7802.
[1] https://review.coreboot.org/c/coreboot/+/39133/42/src/mainboard/kontron/mal1...
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44865 )
Change subject: soc/intel/common/block/smbus: Add config to use ACPI ......................................................................
Patch Set 2: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44865 )
Change subject: soc/intel/common/block/smbus: Add config to use ACPI ......................................................................
Patch Set 10:
It has been a little long since last verification. Can you rebase and pass buildbot verification again before we merge it?
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44865 )
Change subject: soc/intel/common/block/smbus: Add config to use ACPI ......................................................................
soc/intel/common/block/smbus: Add config to use ACPI
Change-Id: Iafa7d40fc21e62f99dbdc2001ab6525a2a77ff50 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44865 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/smbus/Kconfig 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/common/block/smbus/Kconfig b/src/soc/intel/common/block/smbus/Kconfig index fe940cc..818200e 100644 --- a/src/soc/intel/common/block/smbus/Kconfig +++ b/src/soc/intel/common/block/smbus/Kconfig @@ -3,6 +3,13 @@ help Intel Processor common SMBus support
+config SOC_INTEL_COMMON_BLOCK_SMBUS_ACPI_DRIVER + bool + default n + depends on SOC_INTEL_COMMON_BLOCK_SMBUS + help + Intel Processor SMBus ACPI driver support + config SOC_INTEL_COMMON_BLOCK_TCO bool help
-
Hung-Te Lin (Code Review) -
Maxim Polyakov (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)