Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60806 )
Change subject: mb/google/herobrine: Remove unneeded static keyword ......................................................................
mb/google/herobrine: Remove unneeded static keyword
Fixed a couple of variables that were declared static when they didn't need to be (they are being reinitialized at the beginning of each function anyway).
BUG=b:182963902 BRANCH=None TEST=compile herobrine variants
Change-Id: I30a0453fa2201d33b4d73eaef231c58832fce3b2 Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/herobrine/boardid.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/60806/1
diff --git a/src/mainboard/google/herobrine/boardid.c b/src/mainboard/google/herobrine/boardid.c index 6449561..4f11a4d 100644 --- a/src/mainboard/google/herobrine/boardid.c +++ b/src/mainboard/google/herobrine/boardid.c @@ -9,7 +9,7 @@
uint32_t board_id(void) { - static uint32_t id = UNDEFINED_STRAPPING_ID; + uint32_t id = UNDEFINED_STRAPPING_ID; gpio_t pins[3] = { 0 }; if (CONFIG(BOARD_GOOGLE_HEROBRINE_REV0)) { pins[2] = GPIO(75); @@ -34,7 +34,7 @@
uint32_t ram_code(void) { - static uint32_t id = UNDEFINED_STRAPPING_ID; + uint32_t id = UNDEFINED_STRAPPING_ID;
return id; }