Attention is currently required from: John Su, YH Lin, Dtrain Hsu, Ian Feng, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Eric Lai, Amanda Hwang, Ricky Chang. Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62804 )
Change subject: mb/google/brya/var/banshee: Add mic mute switch setting ......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62804/comment/2daa832b_e7dc8017 PS5, Line 13: TEST=emerge-brya coreboot chromeos-bootimage
any evtest log?
localhost ~ # crossystem | grep fwid fwid = Google_Banshee.14505.42.2022_03_22_1356 # [RO/str] Active firmware ID ro_fwid = Google_Banshee.14505.42.2022_03_22_1356 # [RO/str] Read-only firmware ID localhost ~ # evtest No device specified, trying to scan all of /dev/input/event* Available devices: /dev/input/event0: Lid Switch /dev/input/event1: Power Button /dev/input/event2: AT Translated Set 2 keyboard /dev/input/event3: cros_ec_buttons /dev/input/event4: mic_mute_switch /dev/input/event5: PNP0C50:00 093A:0274 Mouse /dev/input/event6: PNP0C50:00 093A:0274 Touchpad /dev/input/event7: Lite-On Technology Corp. ThinkPad USB Keyboard with TrackPoint /dev/input/event8: Lite-On Technology Corp. ThinkPad USB Keyboard with TrackPoint Mouse /dev/input/event9: Lite-On Technology Corp. ThinkPad USB Keyboard with TrackPoint System Control /dev/input/event10: Lite-On Technology Corp. ThinkPad USB Keyboard with TrackPoint Consumer Control /dev/input/event11: sof-rt5682 Headset Jack /dev/input/event12: sof-rt5682 HDMI/DP,pcm=2 /dev/input/event13: sof-rt5682 HDMI/DP,pcm=3 /dev/input/event14: sof-rt5682 HDMI/DP,pcm=4 /dev/input/event15: sof-rt5682 HDMI/DP,pcm=5 Select the device event number [0-15]: 4 Input driver version is 1.0.1 Input device ID: bus 0x19 vendor 0x1 product 0x1 version 0x100 Input device name: "mic_mute_switch" Supported events: Event type 0 (EV_SYN) Event type 5 (EV_SW) Event code 14 (SW_MUTE_DEVICE) state 1 Properties: Testing ... (interrupt to exit) Event: time 1647939954.639995, type 5 (EV_SW), code 14 (SW_MUTE_DEVICE), value 0 Event: time 1647939954.639995, -------------- SYN_REPORT ------------ Event: time 1647939954.648152, type 5 (EV_SW), code 14 (SW_MUTE_DEVICE), value 1 Event: time 1647939954.648152, -------------- SYN_REPORT ------------ Event: time 1647939954.841961, type 5 (EV_SW), code 14 (SW_MUTE_DEVICE), value 0 Event: time 1647939954.841961, -------------- SYN_REPORT ------------ Event: time 1647939954.845026, type 5 (EV_SW), code 14 (SW_MUTE_DEVICE), value 1 Event: time 1647939954.845026, -------------- SYN_REPORT ------------ Event: time 1647939954.920548, type 5 (EV_SW), code 14 (SW_MUTE_DEVICE), value 0 Event: time 1647939954.920548, -------------- SYN_REPORT ------------ Event: time 1647939954.922793, type 5 (EV_SW), code 14 (SW_MUTE_DEVICE), value 1 Event: time 1647939954.922793, -------------- SYN_REPORT ------------ Event: time 1647939957.664608, type 5 (EV_SW), code 14 (SW_MUTE_DEVICE), value 0 Event: time 1647939957.664608, -------------- SYN_REPORT ------------
File src/mainboard/google/brya/variants/banshee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62804/comment/71ce7f32_684ed9f4 PS5, Line 328: register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_F19)"
Is this intended?
The GPP_F22 is active high from HW's feedback.
-
Frank Wu (Code Review)