Attention is currently required from: Hung-Te Lin.
Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85681?usp=email )
Change subject: soc/mediatek/common: Rename GPT_MHZ to TIMER_MHZ for readability
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85681/comment/191dede0_789fb96b?usp... :
PS1, Line 7: Update timer macro name
Or `Rename GPT_MHZ to TIMER_MHZ for readability`
Done
https://review.coreboot.org/c/coreboot/+/85681/comment/9e12acfe_c366716a?usp... :
PS1, Line 11: The new ICs(e.g. mt8196, mt8189) will no longer use GPT, and in order
: to improve code readability, so replace GPT_MHZ of existing Soc's
: with macro name TIMER_MHZ.
nit: space before `(`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85681?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I02f18bfa5b5912f28e322d40cd46823a0095bbf4
Gerrit-Change-Number: 85681
Gerrit-PatchSet: 2
Gerrit-Owner: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Fri, 20 Dec 2024 08:35:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com