Attention is currently required from: Leah Rowe.
Maximilian Brune has posted comments on this change by Leah Rowe. ( https://review.coreboot.org/c/coreboot/+/71024?usp=email )
Change subject: util/ifdtool: bsd-style prototypes, main() on top ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71024/comment/2fd30675_a1f290ff?usp... : PS1, Line 17: Finally, split types and names (for each function) to a new line. For example: : : int : main(int argc, char *argv[]) : { : : } : : Instead of: : : int main(int argc, char *argv[]) : { : : } besides the fact that it doesn't fit in our coding style I also don't see any advantages to that. It is mostly just a pain for searching (aka grepping) of functions.