Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84222?usp=email )
Change subject: soc/mediatek: Remove redundant struct pad_func and PAD_* definitions
......................................................................
Patch Set 2:
(2 comments)
File src/soc/mediatek/common/include/soc/gpio_common.h:
https://review.coreboot.org/c/coreboot/+/84222/comment/9c7d43d3_c82eb853?usp... :
PS2, Line 59: PAD_##name##_FUNC_##func
I didn't notice mt8173 and mt8183 are excluded from CB:84221. […]
Yes.
https://review.coreboot.org/c/coreboot/+/84222/comment/429ac45e_e0f1a589?usp... :
PS2, Line 59: }
I mean, `GPIO_PULL_DOWN` is 0, so the current `PAD_FUNC` macro defined here is equivalent to setting […]
I see your point. I will implement option 3 in next patchset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84222?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I12b8f6749015bff52988208a7c3aa01e952612c6
Gerrit-Change-Number: 84222
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 11 Sep 2024 03:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com