Attention is currently required from: Nick Vaccaro, Scott Chao.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56801 )
Change subject: gimble: enable elan touchscreen
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/gimble/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56801/comment/e36cdea3_14805e16
PS3, Line 138: 300
After confirmed with Elan, they said reset_delay_ms must not lower than 150ms. […]
Please do check up on this later (please file a bug), we have often found that 300ms was not actually required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20a7fd0b370803c14990b77bab302727af197ccb
Gerrit-Change-Number: 56801
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 05 Aug 2021 22:05:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-MessageType: comment