Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons. wouter.eckhardt@prodrive-technologies.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56086 )
Change subject: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
This change effects all variants
Ah, thanks for confimring. I got confused the hda_verb.c file that also in the R4 board variant directory. My bad...
File src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/56086/comment/574cfa92_b48bd41a PS2, Line 8: 0x10ec0888, /* Subsystem ID */
The first ID is the read-only ID, used to identify the codec. […]
My guess would be that it was intended to be used as a second ID to match the verb table to the codec (though that would cause problems for clean devices, since those would not have the updated subsystem ID yet...).
As far as I can tell, it's not used (maybe because of the issue with clean devices?). So I guess we can leave it as is.
-
Name of user not set (Code Review)