[XL] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features

[Michał Kopeć (Code Review)]

Attention is currently required from: Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski.

Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82672?usp=email )

Change subject: ec/dasharo/ec: add Dasharo features
......................................................................

Patch Set 11:

(7 comments)

File src/ec/dasharo/ec/acpi/dasharo.asl:

https://review.coreboot.org/c/coreboot/+/82672/comment/5fb9c0bb_e769faed?usp... :
PS10, Line 3: // Notifications:
            : //   0x80 - hardware backlight toggle
            : //   0x81 - backlight toggle
            : //   0x82 - backlight down
            : //   0x83 - backlight up
            : //   0x84 - backlight color change
            : //   0x85 - OLED screen toggle
> These have been removed from the code, should be removed from here as well.

Removed

https://review.coreboot.org/c/coreboot/+/82672/comment/e2034191_340181c2?usp... :
PS10, Line 11: 	Name (_HID, "XXXX0000") // TODO: Update after we get a valid ACPI HID prefix
> Don't we have one already? https://uefi. […]

Indeed, changed to `DSHR4543`

https://review.coreboot.org/c/coreboot/+/82672/comment/ad94d9b2_af5e1df4?usp... :
PS10, Line 17: 		Debug = "DASH: RSET"
> Here `Debug` is directly written to, in other cases `Printf` is used, even for simple strings. […]

Fixed

File src/ec/dasharo/ec/acpi/ec.asl:

https://review.coreboot.org/c/coreboot/+/82672/comment/65edf809_0ac96e70?usp... :
PS10, Line 95: 			^^^^DASH.RSET()
> Won't it unconditionally turn off airplane mode LED on wake?

It would, if any of the devices we support had an airplane mode led :| Removed all dead airplane mode related code

File src/ec/dasharo/ec/dasharo_ec.c:

https://review.coreboot.org/c/coreboot/+/82672/comment/3ef067b1_3a128d66?usp... :
PS10, Line 43: 2
> REG_DATA

Done

https://review.coreboot.org/c/coreboot/+/82672/comment/28be766f_57748879?usp... :
PS10, Line 52: REG_CMD + 2
> REG_DATA

Done

https://review.coreboot.org/c/coreboot/+/82672/comment/935652f3_5b83fda5?usp... :
PS10, Line 200: #define SPI_ACCESS_SIZE 252
> IIUC this is `(DASHARO_EC_SIZE - REG_DATA - ARRAY_SIZE(read_cmd))` (the last operand defined below,  […]

Changed to `(DASHARO_EC_SIZE - REG_DATA - 2)` and added a comment explaining the `2`