Attention is currently required from: Patrick Rudolph, Lean Sheng Tan, David.Milosevic@9elements.com.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 4:
(7 comments)
File src/mainboard/prodrive/atlas/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/3cf59641_bc7630df PS4, Line 51: switch (access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/bee7dcd8_b3495af1 PS4, Line 89: switch(access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/51225faa_a5a68b2e PS4, Line 89: switch(access) { space required before the open parenthesis '('
File src/mainboard/prodrive/atlas/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/ad97ada8_0f6fc5db PS4, Line 14: static const char* get_smbios_part_number(void); "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/0d09fb1c_8ce93bf4 PS4, Line 41: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/7f5ed9de_7f95a972 PS4, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/vpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/71f8323f_adeff023 PS4, Line 34: switch (vpd) { switch and case should be at the same indent