Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62014 )
Change subject: drivers/smmstore: Expose region device
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/62014/comment/4dca2671_1bb2bb30
PS4, Line 103: ret = CB_ERR;
: } else {
: ret = CB_SUCCESS;
As the other functions in this file return 0 or -1, maybe do the same here for consistency?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62014
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6316b703829590bd6f41c3d4013b4a4660b9cbab
Gerrit-Change-Number: 62014
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 07 Apr 2022 12:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment