build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57805 )
Change subject: soc/intel/common/../cse: Perform D0I3 bit reset/set prior sending EOP ......................................................................
Patch Set 1:
(5 comments)
File src/soc/intel/common/block/cse/cse_eop.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128790): https://review.coreboot.org/c/coreboot/+/57805/comment/e1a3880b_c2c0ee11 PS1, Line 25: CSE_MMIO_ENABLE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128790): https://review.coreboot.org/c/coreboot/+/57805/comment/445b53d8_b4e9c6a3 PS1, Line 25: CSE_MMIO_ENABLE, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128790): https://review.coreboot.org/c/coreboot/+/57805/comment/d882e9e9_42db0698 PS1, Line 26: CSE_MMIO_DISABLE code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128790): https://review.coreboot.org/c/coreboot/+/57805/comment/09cdb4f2_348f55fb PS1, Line 26: CSE_MMIO_DISABLE please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128790): https://review.coreboot.org/c/coreboot/+/57805/comment/67d2e55a_ab3d4a30 PS1, Line 217: static void cse_config_mmio( enum cse_config_status status) space prohibited after that open parenthesis '('