Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61095 )
Change subject: soc/amd/sabrina/include/smu: update mailbox SMN addresses ......................................................................
soc/amd/sabrina/include/smu: update mailbox SMN addresses
The SMU message response register was moved compared to Cezanne.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ie384de52b1efb1d52f9018315a4b72916a4c9cee Reviewed-on: https://review.coreboot.org/c/coreboot/+/61095 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jason Glenesk jason.glenesk@gmail.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/sabrina/include/soc/smu.h M src/soc/amd/sabrina/smu.c 2 files changed, 1 insertion(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Jason Glenesk: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/sabrina/include/soc/smu.h b/src/soc/amd/sabrina/include/soc/smu.h index e4b8e15..d4990c0 100644 --- a/src/soc/amd/sabrina/include/soc/smu.h +++ b/src/soc/amd/sabrina/include/soc/smu.h @@ -1,13 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* TODO: Check if this is still correct */ - #ifndef AMD_SABRINA_SMU_H #define AMD_SABRINA_SMU_H
/* SMU mailbox register offsets in SMN */ #define SMN_SMU_MESG_ID 0x3b10528 -#define SMN_SMU_MESG_RESP 0x3b10564 +#define SMN_SMU_MESG_RESP 0x3b10578 #define SMN_SMU_MESG_ARGS_BASE 0x3b10998
#define SMU_NUM_ARGS 6 diff --git a/src/soc/amd/sabrina/smu.c b/src/soc/amd/sabrina/smu.c index dd83713..1496957 100644 --- a/src/soc/amd/sabrina/smu.c +++ b/src/soc/amd/sabrina/smu.c @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* TODO: Check if this is still correct */ - #include <console/console.h> #include <amdblocks/smu.h> #include <soc/smu.h>