Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56080 )
Change subject: ec/roda/it8518/acpi: Don't hard-code GPE offset ......................................................................
ec/roda/it8518/acpi: Don't hard-code GPE offset
The GPE offset of 16 is PCH specific.
Built roda/rw11 with `BUILD_TIMELESS=1` and coreboot.rom remains the same.
Change-Id: I4ec38fc28d2436f84a090bb4ab38f20612cfd795 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/56080 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/ec/roda/it8518/acpi/ec.asl M src/mainboard/roda/rv11/acpi/ec.asl 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/ec/roda/it8518/acpi/ec.asl b/src/ec/roda/it8518/acpi/ec.asl index de121c6..28f9c88 100644 --- a/src/ec/roda/it8518/acpi/ec.asl +++ b/src/ec/roda/it8518/acpi/ec.asl @@ -6,7 +6,7 @@ { Name (_HID, EISAID ("PNP0C09")) // ACPI Embedded Controller Name (_UID, 1) - Name (_GPE, Add(EC_SCI_GPI, 16)) // GPE for Runtime SCI + Name (_GPE, EC_SCI_GPI) Name (PWRS, 1) Name (LIDS, 1)
diff --git a/src/mainboard/roda/rv11/acpi/ec.asl b/src/mainboard/roda/rv11/acpi/ec.asl index e343930..468a329 100644 --- a/src/mainboard/roda/rv11/acpi/ec.asl +++ b/src/mainboard/roda/rv11/acpi/ec.asl @@ -1,4 +1,4 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#define EC_SCI_GPI 7 +#define EC_SCI_GPI (16 + 7) #include <ec/roda/it8518/acpi/ec.asl>