Attention is currently required from: Bao Zheng, Felix Held, Julius Werner, Paul Menzel, Zheng Bao.
Maximilian Brune has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84338?usp=email )
Change subject: amdfwtool: Check fletcher of each header ......................................................................
Patch Set 5:
(3 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84338/comment/57d10763_a99794b0?usp... : PS5, Line 540: psp_directory_table *dir = directory; nit: Use same naming scheme as for the others (e.g. pdir instead of dir)
https://review.coreboot.org/c/coreboot/+/84338/comment/2bb5a0af_fd54015d?usp... : PS5, Line 544: uint32_t cookie = ((psp_directory_table *)directory)->header.cookie; Do you need the extra type conversion? Can't you just use the `dir` from above?
https://review.coreboot.org/c/coreboot/+/84338/comment/178d4ee7_f6db04cb?usp... : PS5, Line 549: if (directory == NULL) You should probably do this check before dereferencing `directory` above