Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31859
Change subject: mb/google/arcada: add Kconfig option to enable WLAN SAR ......................................................................
mb/google/arcada: add Kconfig option to enable WLAN SAR
Enable WLAN SAR power table.
BUG=b:123552641 TEST=Verified WLAN SAR power table forllows VPD setting
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I882b1c7ed0b1142a84eb338142e1c984df45eeba --- M src/mainboard/google/sarien/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31859/1
diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 462ff06..1f5e0fb 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -4,7 +4,6 @@ select BOARD_ROMSIZE_KB_32768 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID - select DRIVERS_INTEL_ISH if BOARD_GOOGLE_ARCADA select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select EC_GOOGLE_WILCO @@ -25,6 +24,9 @@ select TPM2 select MAINBOARD_USES_IFD_EC_REGION select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_SARIEN + select USE_SAR + select SAR_ENABLE +
if BOARD_GOOGLE_BASEBOARD_SARIEN
Hello Lijian Zhao, Duncan Laurie, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31859
to look at the new patch set (#2).
Change subject: mb/google/arcada: add Kconfig option to enable WLAN SAR ......................................................................
mb/google/arcada: add Kconfig option to enable WLAN SAR
Enable WLAN SAR power table.
BUG=b:123552641 TEST=Verified WLAN SAR power table forllows VPD setting
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I882b1c7ed0b1142a84eb338142e1c984df45eeba --- M src/mainboard/google/sarien/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31859/2
Hello Lijian Zhao, Duncan Laurie, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31859
to look at the new patch set (#3).
Change subject: mb/google/arcada: add Kconfig option to enable WLAN SAR ......................................................................
mb/google/arcada: add Kconfig option to enable WLAN SAR
Enable WLAN SAR power table.
BUG=b:123552641 TEST=Verified WLAN SAR power table forllows VPD setting
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I882b1c7ed0b1142a84eb338142e1c984df45eeba --- M src/mainboard/google/sarien/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31859/3
Hello Lijian Zhao, Duncan Laurie, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31859
to look at the new patch set (#4).
Change subject: mb/google/arcada: add Kconfig option to enable WLAN SAR ......................................................................
mb/google/arcada: add Kconfig option to enable WLAN SAR
Enable WLAN SAR power table.
BUG=b:123552641 TEST=Verified WLAN SAR power table forllows VPD setting
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I882b1c7ed0b1142a84eb338142e1c984df45eeba --- M src/mainboard/google/sarien/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31859/4
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31859 )
Change subject: mb/google/arcada: add Kconfig option to enable WLAN SAR ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31859 )
Change subject: mb/google/arcada: add Kconfig option to enable WLAN SAR ......................................................................
mb/google/arcada: add Kconfig option to enable WLAN SAR
Enable WLAN SAR power table.
BUG=b:123552641 TEST=Verified WLAN SAR power table forllows VPD setting
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I882b1c7ed0b1142a84eb338142e1c984df45eeba Reviewed-on: https://review.coreboot.org/c/coreboot/+/31859 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/sarien/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 462ff06..8f8b37c 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -25,6 +25,8 @@ select TPM2 select MAINBOARD_USES_IFD_EC_REGION select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_SARIEN + select USE_SAR + select SAR_ENABLE
if BOARD_GOOGLE_BASEBOARD_SARIEN