[M] Change in coreboot[main]: inteltool: improve support for Elkhart Lake

[Angel Pons (Code Review)]

Attention is currently required from: Alexander Couzens, Paul Menzel, Pratikkumar V Prajapati.

Angel Pons has posted comments on this change by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/75214?usp=email )

Change subject: inteltool: improve support for Elkhart Lake
......................................................................

Patch Set 7: Code-Review+2

(2 comments)

File util/inteltool/spi.c:

https://review.coreboot.org/c/coreboot/+/75214/comment/9918cb60_d7b4b5d0?usp... :
PS7, Line 45: static const io_register_t elkhart_bios_cntl_registers[] = {
            : 	{ 0x0, 1, "BIOSWE - write enable" },
            : 	{ 0x1, 1, "BLE - lock enable" },
            : 	{ 0x2, 1, "ESPI - eSPI Enable Pin Strap" },
            : 	{ 0x3, 1, "Reserved" },
            : 	{ 0x4, 1, "TS - TopSwapStatus" },
            : 	{ 0x5, 1, "EISS - Enable InSMM.STS" },
            : 	{ 0x6, 1, "BBS - Boot BIOS Strap" },
            : 	{ 0x7, 1, "BILD - BIOS Interface Lock-Down" },
            : 	{ 0x8, 1, "BWPDS - BIOS Write Protect Disable Status" },
            : 	{ 0x9, 1, "Reserved" },
            : 	{ 0xa, 1, "BWRS - BIOS Write Status" },
            : 	{ 0xb, 1, "BWRE - BIOS Write Reporting (Async-SMI) Enable" },
            : };
These are bitfields, right? I would use decimal for bit offsets (ADL seems to be wrong in that regard)

https://review.coreboot.org/c/coreboot/+/75214/comment/5cc104e7_15d48e6d?usp... :
PS7, Line 125: 	/* 0x10 .. 0x4f are filled with data */
Would it make sense to print the data?