Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Julius Werner, Martin L Roth, Yu-Ping Wu.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75707?usp=email )
Change subject: Rename CBFS master header -> CBFS main header ......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75707/comment/c0992243_e7682379 : PS5, Line 9: pupose
typo: purpose
Done
https://review.coreboot.org/c/coreboot/+/75707/comment/07b305fd_ee10a649 : PS5, Line 9: Calling it the main header is more descriptive of its pupose : and should therefore be preferred.
I don't think that it's more descriptive, rather more confusing. […]
Your opinion on this is noted. Main suggests that it is the overarching structure that contains values that are relevant for all other entries. Neither of your suggestions catch that, and since nothing is initialized nor pointed to here, and the term boot is somewhat overloaded in this type of project, I think main is still the clearest description.
Patchset:
PS5:
Unrelated to my other comment, I think the whole discussion about "master vs main" is too political […]
I am unclear why you are bringing politics to this discussion. I guess I don't understand why the term main header is political for you, or why you think it should be avoided?
Unless the header is removed, we should make sure that it is concise. Feel free to point me to the patches that remove this header, preferably outside of the scope of this patch.
File Documentation/releases/coreboot-4.2-relnotes.md:
PS5:
I wouldn't change the release notes since they relate to a specific state of the tree.
Done
-
Stefan Reinauer (Code Review)