Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro.
Paul Menzel has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/83755?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox: Tune Touchpad I2C parameters ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83755/comment/e0db9607_f4f7e001?usp... : PS1, Line 9: that it meets the : I2C fast mode specification What does it require?
https://review.coreboot.org/c/coreboot/+/83755/comment/5da4a7ca_500ec147?usp... : PS1, Line 13: BIOS firmware
https://review.coreboot.org/c/coreboot/+/83755/comment/fc2cc217_8e0fe6b2?usp... : PS1, Line 13: Confirm the I2C bus : frequency, rise and fall times meet the specification. Please list the measured values.