Attention is currently required from: Patrick Rudolph, Maximilian Brune, Angel Pons, Julius Werner.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61960 )
Change subject: bsd/cb_err: Add error code for UEFI variable store
......................................................................
Patch Set 13:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/cb_err.h:
https://review.coreboot.org/c/coreboot/+/61960/comment/39dba791_23f69f69
PS11, Line 46: CB_EFI_FVH_INVALID = -500, /**< UEFI FVH is corrupted */
Not to be padentic, but for the comment, could you write out the FVH abbreviation. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61960
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6baea9fb138d1a2755d22a3d587105793adb9c90
Gerrit-Change-Number: 61960
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Joey Madafferi
joeymadafferi@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Milosevic
David.Milosevic@9elements.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Patrick Rudolph
Gerrit-Comment-Date: Fri, 03 Feb 2023 12:03:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment