John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................
mb/google/zork/var/vliboz: update telemetry settings
Update telemetry settings.
VDD Slope : 32643 -> 26939 VDD Offset: 208 -> 125 SOC Slope : 22742 -> 20001 SOC Offset: -83 -> 168
BUG=b:171668654 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test report
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/48288/1
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index 3b3bdd4..9d6f132 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -18,10 +18,10 @@
# End : OPN Performance Configuration
- register "telemetry_vddcr_vdd_slope_mA" = "32643" - register "telemetry_vddcr_vdd_offset" = "208" - register "telemetry_vddcr_soc_slope_mA" = "22742" - register "telemetry_vddcr_soc_offset" = "-83" + register "telemetry_vddcr_vdd_slope_mA" = "26939" + register "telemetry_vddcr_vdd_offset" = "125" + register "telemetry_vddcr_soc_slope_mA" = "20001" + register "telemetry_vddcr_soc_offset" = "168"
# USB OC pin mapping register "usb_port_overcurrent_pin[1]" = "USB_OC_NONE" # LTE instead of USB C1
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................
Patch Set 1: Code-Review+1
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................
Patch Set 1: Code-Review+1
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................
Patch Set 1: Code-Review+1
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................
Patch Set 1: Code-Review+2
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Martin Roth, Peichao Wang, Rob Barnes, chris wang, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48288
to look at the new patch set (#2).
Change subject: mb/google/zork/var/vilboz: update telemetry settings ......................................................................
mb/google/zork/var/vilboz: update telemetry settings
Update telemetry settings.
VDD Slope : 32643 -> 26939 VDD Offset: 208 -> 125 SOC Slope : 22742 -> 20001 SOC Offset: -83 -> 168
BUG=b:171668654 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test report
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/48288/2
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vilboz: update telemetry settings ......................................................................
Patch Set 2: Code-Review+1
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vilboz: update telemetry settings ......................................................................
Patch Set 2:
John, need rebase this CL to master
Hello build bot (Jenkins), Martin Roth, Peichao Wang, Rob Barnes, chris wang, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48288
to look at the new patch set (#3).
Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................
mb/google/zork/var/vilboz: Update telemetry settings
Update telemetry settings.
VDD Slope : 32643 -> 26939 VDD Offset: 208 -> 125 SOC Slope : 22742 -> 20001 SOC Offset: -83 -> 168
BUG=b:171668654 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test report
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/48288/3
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................
Patch Set 3: Code-Review+1
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................
Patch Set 3: Code-Review+2
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................
Patch Set 3: Code-Review+1
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................
mb/google/zork/var/vilboz: Update telemetry settings
Update telemetry settings.
VDD Slope : 32643 -> 26939 VDD Offset: 208 -> 125 SOC Slope : 22742 -> 20001 SOC Offset: -83 -> 168
BUG=b:171668654 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test report
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48288 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified John Su: Looks good to me, but someone else must approve EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index a19443d..a3c2c97 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -18,10 +18,10 @@
# End : OPN Performance Configuration
- register "telemetry_vddcr_vdd_slope_mA" = "32643" - register "telemetry_vddcr_vdd_offset" = "208" - register "telemetry_vddcr_soc_slope_mA" = "22742" - register "telemetry_vddcr_soc_offset" = "-83" + register "telemetry_vddcr_vdd_slope_mA" = "26939" + register "telemetry_vddcr_vdd_offset" = "125" + register "telemetry_vddcr_soc_slope_mA" = "20001" + register "telemetry_vddcr_soc_offset" = "168"
# USB OC pin mapping register "usb_port_overcurrent_pin[1]" = "USB_OC_NONE" # LTE instead of USB C1
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )
Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................
Patch Set 4: Code-Review+2