build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/14921 )
Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.h File payloads/libpayload/include/stdlib.h:
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.h... PS4, Line 81: #define calloc(n,s) ({ \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.h... PS4, Line 93: #define realloc(p,s) ({ \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.h... PS4, Line 97: printf("realloc(%p, %zu) called from %s:%s:%d...\n", __p, __s, \ Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.h... PS4, Line 99: printf("PRE realloc\n"); \ Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.h... PS4, Line 102: printf("POST realloc (ptr = %p)\n", ptr); \ Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.h... PS4, Line 106: #define memalign(a,s) ({ \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.h... PS4, Line 130: #define dma_memalign(a,s) ({ \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/libc/malloc.c File payloads/libpayload/libc/malloc.c:
https://review.coreboot.org/#/c/14921/4/payloads/libpayload/libc/malloc.c@48... PS4, Line 483: printf(" found memalign region. %u free, %zu required\n", reg->free, (size + align - 1)/align); line over 96 characters