Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 )
Change subject: ec/google/chromeec: fix the error status handling
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/31585/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31585/1//COMMIT_MSG@8
PS1, Line 8:
: google_chromeec_command() can return non-zero number (both positive
: and negative) to indicate error.
I suggest we define/discuss the return values at https://bugs.chromium. […]
Paul, we'll go with patchset 1 to fix the issue for flapjack. Patchset 1 and https://review.coreboot.org/c/coreboot/+/31613 should make all consistent.
YH will create a separate CL for Patchset 6, which further changes the definition of the API by additionally accepting negative integers as error code. What do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c
Gerrit-Change-Number: 31585
Gerrit-PatchSet: 6
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Feb 2019 17:00:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daisuke Nojiri
dnojiri@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: YH Lin
yueherngl@google.com
Gerrit-MessageType: comment