Attention is currently required from: Felix Held, Paul Menzel.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74363?usp=email )
Change subject: mb/purism/librem_cnl: Define CMOS layout for Librem Mini v1/v2 ......................................................................
Patch Set 10:
(5 comments)
Patchset:
PS2:
Looks like if I enable HAVE_OPTION_TABLE, USE_OPTION_TABLE, and STATIC_OPTION_TABLE it is quite clos […]
Done
Patchset:
PS10: Resolved the remaining comments since these changes were moved to the earlier patches, which are now merged
File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/74363/comment/ac5372da_6c69108c : PS9, Line 7: select HAVE_CMOS_DEFAULT
Ack
Done
File src/mainboard/purism/librem_cnl/variants/librem_mini/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74363/comment/5b06269b_599d38e5 : PS2, Line 7: /* Create a cbfs file called 'board_settings' to configure settings: : * Byte 0: EC automatic power on (EC_POWER_ON_*) : */
Please use the recommended multi-line comment styles from the coding style.
Done
https://review.coreboot.org/c/coreboot/+/74363/comment/48cec385_6a70f135 : PS2, Line 21: uint8_t ec_power_on = 0;
It's reading a 1-byte field from the board settings file with memcpy. […]
Done