Attention is currently required from: Ethan Tsao, Ravishankar Sarawadi, Tim Wawrzynczak, Paul Menzel, Raj Astekar, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61389 )
Change subject: soc/intel/graphics: Create Kconfig for mapping graphic memory base
......................................................................
Patch Set 19:
(1 comment)
File src/soc/intel/common/block/graphics/Kconfig:
https://review.coreboot.org/c/coreboot/+/61389/comment/44dcff38_af00050b
PS19, Line 26: to
: reach at DSM
In future platform, GMADR is replaced by LMEMBAR which is fixed map to DSM/GSM.
There is document 643504(FAS) mention it.
Alas, I can't access that document, might be too early. However, the LMEMBAR
is a concept from Intel's discrete graphics projects. So it seems likely
true that they replaced GMADR for future integrated graphics as well.
But if that's the case, why alter functions for GMADR instead of adding
functions for LMEMBAR? They are different concepts. LMEMBAR + offset is
not the same as GMADR (the former is about physical memory with an offset
and the latter about virtual memory). It just happens to provide the same
results wrt. the pre-OS framebuffer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b1e34ada9b895dabcdc8116d2470e8831ed0a9e
Gerrit-Change-Number: 61389
Gerrit-PatchSet: 19
Gerrit-Owner: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Feb 2022 13:17:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Ethan Tsao
ethan.tsao@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment