Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85751?usp=email )
Change subject: soc/mediatek/mt8196: Set SPMI-P SCL/SDA SoC PD ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85751/comment/d97874b6_8b793d2b?usp... : PS5, Line 10: spmi
SPMI
Done
https://review.coreboot.org/c/coreboot/+/85751/comment/4265777a_2e3cd6dc?usp... : PS5, Line 10: clk
clock
Done
File src/soc/mediatek/mt8196/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/85751/comment/a79559ad_b1afc73f?usp... : PS1, Line 178: setbits32p(SPMI_SCL_P_PD_ADDR, : BIT(SPMI_SCL_P_PD_OFFSET) | BIT(SPMI_SDA_P_PD_OFFSET));
This is identical to […]
Done
https://review.coreboot.org/c/coreboot/+/85751/comment/5af3d8b4_a5300dee?usp... : PS1, Line 177: if (dev->slvid == SPMI_SLAVE_6) { : setbits32p(SPMI_SCL_P_PD_ADDR, : BIT(SPMI_SCL_P_PD_OFFSET) | BIT(SPMI_SDA_P_PD_OFFSET)); : printk(BIOS_INFO, "%s, Set SoC PD for SPMI-P SCL/SDA, [0x%x] = 0x%x\n", : __func__, SPMI_SCL_P_PD_ADDR, read32p(SPMI_SCL_P_PD_ADDR)); : }
This setting also effects other slaves, right ? Should we revert the setting for other slaves ? Plea […]
Because the 6316 with slave id 6 is the first PMIC in SPMI-P, just need to set one time.