Attention is currently required from: Shuming Chu (Shuming), Arthur Heymans, TangYiwei.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68910 )
Change subject: drivers/ocp/dmi: Fix smbios type 11 get wrong ppin value for second socket ......................................................................
Patch Set 4:
(3 comments)
File src/drivers/ocp/dmi/smbios.c:
https://review.coreboot.org/c/coreboot/+/68910/comment/9433eca6_7f875a79 PS4, Line 205: static int get_logic_cpu(int node) Should we name the variable as socket instead of node?
https://review.coreboot.org/c/coreboot/+/68910/comment/b2a3cc04_7672b97f PS4, Line 207: for (int logic_cpu = 0; logic_cpu < CONFIG_MAX_CPUS; logic_cpu++) { Should we loop through all logical cpus, instead of all sockets (CPUs)?
https://review.coreboot.org/c/coreboot/+/68910/comment/b3594729_4babde77 PS4, Line 259: get_logic_cpu(1), 100 * USECS_PER_MSEC) != what if the return value of get_logic_cpu() is -1?