Attention is currently required from: Jason Glenesk, Raul Rangel, Subrata Banik, Marshall Dawson, Tim Wawrzynczak, Paul Menzel, Name of user not set #1003801, Andrey Petrov, Patrick Rudolph. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 )
Change subject: drivers/intel/fsp2_0/include/fsp: fix fsp_header ......................................................................
Patch Set 8:
(4 comments)
File src/drivers/intel/fsp2_0/header_display.c:
https://review.coreboot.org/c/coreboot/+/58869/comment/e47c200f_060c169b PS8, Line 28: %s this probably needs to be %.8s; see my comment below
https://review.coreboot.org/c/coreboot/+/58869/comment/5c46a005_f20941d0 PS8, Line 29: hdr->image_id this is no longer a zero terminated c string, so you need to adjust the printk format specifier to only use 8 characters
File src/drivers/intel/fsp2_0/include/fsp/info_header.h:
https://review.coreboot.org/c/coreboot/+/58869/comment/6a4898f0_b53a083d PS8, Line 29: api_entry_num this should probably be res2. a change from the fsp info header block from the fsp 1.1 to fsp 2.0 was "Renamed ApiEntryNum to Reserved2" and this header file is specific to fsp2.x
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/58869/comment/442482fc_41a532d3 PS8, Line 54: if (!looks_like_fsp_header(raw_hdr)) i'd pass a struct fsp_header to looks_like_fsp_header instead of the raw binary to avoid using hard-coded offsets there too. that's something for a separate follow-up patch though
-
Felix Held (Code Review)