Change in coreboot[master]: util/inteltool: Add support for Alder Lake chips detection and GPIOs
Attention is currently required from: Felix Singer, Michał Żygowski, Stefan Reinauer, Michael Niewöhner. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63374 )
Change subject: util/inteltool: Add support for Alder Lake chips detection and GPIOs ......................................................................
Patch Set 8:
(6 comments)
File util/inteltool/gpio_names/alderlake_h.h:
https://review.coreboot.org/c/coreboot/+/63374/comment/c655fb3e_cc58a901 PS8, Line 102: const char *const alderlake_pch_h_group_d_names[] = {
The DOC #618659 has copy-pasta error, the NF6 column should obviously contain: […]
Done
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/63374/comment/a6c63acf_1f658ebb PS8, Line 356: #define PCI_DEVICE_ID_INTEL_CORE_ADL_ID_H_6_8 0x4641 /* Alderlake H 6+8 */
This is H processor line, different from S and HX line which the dump/patch is for.
Removed
https://review.coreboot.org/c/coreboot/+/63374/comment/20455535_0a97ecbd PS8, Line 436: #define PCI_DEVICE_ID_INTEL_ADL_S_GT1 0x4680
There are more IDs based on the stepping for S LGA and HX SBGA
Added remaining device IDs for ADL-S
https://review.coreboot.org/c/coreboot/+/63374/comment/43b47e20_43a4d027 PS8, Line 437: #define PCI_DEVICE_ID_INTEL_ADL_P_GT2 0x46a0 : #define PCI_DEVICE_ID_INTEL_ADL_M_GT1 0x46c0
Not an ADL-S/HX GT devices
Removed
File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/63374/comment/dae05307_4cebb5fa PS8, Line 173: { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CORE_ADL_ID_H_6_8, : "12th generation (Alder Lake H family) Core Processor (Mobile)" },
Not an ADL-S/HX line
Removed
https://review.coreboot.org/c/coreboot/+/63374/comment/2910fd96_6a7aeabc PS8, Line 545: { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ADL_P_GT2, : "Intel(R) AlderLake-P GT2" }, : { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ADL_M_GT1, : "Intel(R) AlderLake-M GT1" },
Not an ADL-S/HX GT devices
Removed
-
Michał Kopeć (Code Review)