Attention is currently required from: Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63058 )
Change subject: arch/arm: Fix assembling files with clang ......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1: Are we trying to do clang again? I thought we figured out it was a lost cause last time?
File src/arch/arm/libgcc/lib1funcs.S:
https://review.coreboot.org/c/coreboot/+/63058/comment/0da25a91_066ab7fc PS1, Line 70: movne \curbit, \curbit, lsr #4 @ No, any more bits to do? Are you trying to copy what 'ARM: 8844/1: use unified assembler in assembly files' did in Linux? That just replaced the MOVNES with MOVSNE, which is just a different syntax for the same instruction. But you're actually removing the S bit and turning this into a different instruction here, which would break the code.
File src/arch/arm/memset.S:
https://review.coreboot.org/c/coreboot/+/63058/comment/7cbebe0c_20610627 PS1, Line 46: Should still use tabs to align like the rest of the code.
https://review.coreboot.org/c/coreboot/+/63058/comment/cede5a9b_fad23c8f PS1, Line 111: strle r1, [ip], #1 @ 1 This is changing the instruction too.
-
Julius Werner (Code Review)